Some allowlist third parties show up on the graph
biancadanforth opened this issue · 2 comments
biancadanforth commented
See this comment for an explanation.
I believe this is a related issue to #110 .
biancadanforth commented
Basically, youtube starts out as a first party, and later becomes an allowlisted third party (so that it's firstParty key is set to false and isVisible key is also set to false). This means when we refresh the page, getAll, which only returns nodes that are either firstParty or isVisible true, ignores youtube, so any nodes it was originally connected to in the visualization lose their youtube link.
In general, the logic of setThirdParty should be such that firstParty and isVisible should never be changed if they are ever true.
jonathanKingston commented
Should be fixed with latest patch.