mozilla/mig

Move GPG tests out of client.NewClient

ameihm0912 opened this issue · 4 comments

ameihm0912 commented

NewClient currently runs a test to see if it can obtain a signed token to validate the key ring is accessible.

There are some cases where client functions are used where the PGP signature is not actually required. An example is a scenario where you want to generate and display a JSON action (mig-cmd's -p option).

A separate function to test the GPG integration would be useful as it could be called explicitly prior to entering any code where signing will be occurring, and we just wouldn't test the integration when signing is not required.

scriptonist commented

Hi. I would love to take this issue. I'm a beginner and pretty new to the mig project.

Bubblemelon commented

Hello @scriptonist, did you get to resolve this issue?

scriptonist commented

I'm very sorry. I totally forgot about this since I was not assigned.

vbmade2000 commented

@ameihm0912 I think this issue can be closed.