Missing tags? ... e.g., v0.11.4
rickhg12hs opened this issue · 8 comments
I can't be sure since I'm a Rust noob, but I think the absence of mp4parse v0.11.4 is causing fselect to have build errors for me.
Have previous tags been removed?
There never was an 0.11.4 tag. Our releases went straight from 0.10.1 to 0.11.5. I'm not familiar with fselect, but if you can say more about how your build is failing I might be able to help.
I'm going to close this issue since I don't think this is a defect in mp4parse, but feel free to keep posting here and we can reopen it if there are changes to be made.
Is this the repo for the Rust crate mp4parse? If so, that shows a version history which includes v0.11.4.
FYI, this is the fselect project I mentioned. https://github.com/jhspetersson/fselect
Am I looking at the wrong mp4parse?
Oh weird. I think I must've made a mistake and published on crates.io without ever creating an appropriate tag in the github repo. I think yanking that version from crates.io would probably be the best thing. Any objection to me doing that?
Wouldn't it be best to create the tags? You can see the commit and when the versions were bumped in Cargo.toml histories like in https://github.com/mozilla/mp4parse-rust/commits/master/mp4parse/Cargo.toml
The problem is that mp4parse was updated to 0.11.4 in October 2019 and mp4parse_capi was updated to 0.11.4 in April 2020, so there's not a good point to put in a tag on the repo that covers both. That was my mistake and I'll be careful to avoid making it again going forward. To avoid confusion, I think the best thing is to get rid of the 0.11.4 versions from crates.io. There isn't anything specific to that release that you need is there? 0.11.5 should be superior in every way.
Well, v0.11.4 has mp4parse::MediaContext::new() but v0.11.5 doesn't ... which happens to break fselect builds since its Cargo.toml has only mp4parse = "0.11". I suppose fselect developers will need to update their Cargo.toml to workaround this breaking change.
Ok, 0.11.4 for mp4parse is yanked from crates.io (mp4parse_capi never had a 0.11.4 release). By the way, it's not gone, it can still be accessed if you explicitly request that version, but it won't be the default for a fuzzy match and given the confusion I think it's better for both crates to have the same versions available.
FYI, fselect has upgraded its mp4parse usage to v0.11.5 now. jhspetersson/fselect@2b7141b