mozilla/nixpkgs-mozilla

rr fails to build when using this overlay with newer nixpkgs

ckoparkar opened this issue · 5 comments

ckoparkar commented

As of NixOS/nixpkgs@ad97a48, rr in nixpkgs has switched back to accepting a stdenv argument instead of gcc9Stdenv. As a result, rr fails to build when using this overlay with newer nixpkgs:

error: anonymous function at /nix/store/.../pkgs/development/tools/analysis/rr/default.nix:1:1 called with unexpected argument 'gcc9Stdenv'

       at /nix/store/.../lib/customisation.nix:72:16:

           71|     let
           72|       result = f origArgs;
             |                ^
           73|
(use '--show-trace' to show detailed location information)

I believe this could be fixed by reverting 66b51ed.

ckoparkar commented

@Artturin It looks like I created this PR too soon. I'm afraid I don't know enough Nix to follow your suggestion. Are you saying that this is something that can be / should be fixed without making changes to this overlay?

Artturin commented

rr-overlay.nix is unnecessary because rr already has i686-linux in its supported platforms

ckoparkar commented

Got it, thanks!

It looks like the upstream rr package has supported i686 for quite some time (NixOS/nixpkgs@541d30a).

What do you think @nbp?

nbp commented

I am ok with removing it.