Code review bot for ESLint missed trailing white space in new file

Question

Code review bot for ESLint missed trailing white space in new file

Closed this issue 6 years ago · 4 comments

I was testing the patch for https://phabricator.services.mozilla.com/D12983 (diff 1) locally, and noticed that there's trailing whitespace on line 131 of browser_library_warnOnOpen.js - which is a new file in that patch.

Seeing as ESLint picked that up when run locally, I'd have expected the code review bot to pick that up as well.

Answer 1 · 2018-11-27T17:07:51.000Z

This is very similar to #1674, which should have been fixed by #1679.

Answer 2 · 2018-11-27T17:10:50.000Z

It looks like the task analyzing that differential timed out: https://tools.taskcluster.net/tasks/E0uJ-4pxSB-UcG3ajk7u4A.

Answer 3 · 2018-11-27T17:21:07.000Z

I've retriggered it to see if it was a temporary issue.

Answer 4 · 2018-11-27T18:19:02.000Z

Not sure what's wrong with this task, but I don't seem to be able to retrigger it successfully. Anyway, I think this was an intermittent issue, feel free to reopen if it happens again.