Coverity posts pre-existing issues unrelated to the patch

Question

Coverity posts pre-existing issues unrelated to the patch

Closed this issue 6 years ago · 9 comments

Phabricator URL: https://phabricator.services.mozilla.com/D19760

Problem: I'm all for static-analysis, but when a file has pre-existing issues reporting them on every revision that touches this file gets very noisy very fast :)

Answer 1 · 2019-02-14T17:18:33.000Z

Yeah, this is a bug, should be fixed today or tomorrow

Answer 2 · 2019-02-14T17:18:50.000Z

Hello Jan,

Thanks for reporting this issue and I'm sorry you're having this bad experience, I'm aware of the issue and we have a fix for it #1884.
This fix will be deployed to PROD as soon as possible.

If you encounter more issues please feel free to ping me directly on IRC.

ANdi

Answer 3 · 2019-02-14T17:19:41.000Z

Fantastic! Thanks to both of you :)

Answer 4 · 2019-02-14T18:56:10.000Z

One more occurrence: https://phabricator.services.mozilla.com/D19779

Answer 5 · 2019-02-14T19:34:01.000Z

We’ve pushed the fix to the testing environment. Tomorrow we will push it in production.

Answer 6 · 2019-02-14T19:57:50.000Z

And in the meantime I've disabled Coverity on production.

Answer 7 · 2019-02-15T15:27:42.000Z

Production has been redeployed with the fix and Coverity has been re-enabled.

Answer 8 · 2019-05-14T08:42:54.000Z

I'm seeing this behavior again, for example https://phabricator.services.mozilla.com/D31038#912541

Is this expected or a bug?

Answer 9 · 2019-05-14T09:22:15.000Z

It's now expected, as we publish Coverity issues for any modified files in a patch (an issue introduced by a patch may be detected at some other place by Coverity).