x86 C ABI struct passing does not work for small structs
Closed this issue · 7 comments
brson commented
See run-pass/extern-pass-TwoU8s.rs and run_pass/extern-pass/TwoU16s.rs
june0cho commented
Still reproduces.
alexcrichton commented
These appear to have been fixed as part of 0479d94
huonw commented
Closing an issue without un-xfailing the tests! The horror!
(I'm landing the un-xfail in #8932.)
huonw commented
Aaaaaand, it looks like this isn't fixed: http://buildbot.rust-lang.org/builders/auto-linux-32-nopt-t/builds/354/steps/test/logs/stdio
[...]
error: test run failed!
command: i686-unknown-linux-gnu/test/run-pass/extern-pass-TwoU8s.stage2-i686-unknown-linux-gnu
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
task <unnamed> failed at 'assertion failed: `(left == right) && (right == left)` (left: `TwoU8s{one: 22u8, two: 23u8}`, right: `TwoU8s{one: 22u8, two: 0u8}`)', /home/rustbuild/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/test/run-pass/extern-pass-TwoU8s.rs:28
------------------------------------------
task <unnamed> failed at 'explicit failure', /home/rustbuild/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/compiletest/runtest.rs:778
test [run-pass] run-pass/extern-pass-TwoU8s.rs ... FAILED
test [run-pass] run-pass/extern-pass-TwoU64s-ref.rs ... ok
test [run-pass] run-pass/extoption_env-not-defined.rs ... ok
error: test run failed!
command: i686-unknown-linux-gnu/test/run-pass/extern-pass-TwoU16s.stage2-i686-unknown-linux-gnu
stdout:
------------------------------------------
------------------------------------------
stderr:
------------------------------------------
task <unnamed> failed at 'assertion failed: `(left == right) && (right == left)` (left: `TwoU16s{one: 22u16, two: 23u16}`, right: `TwoU16s{one: 22u16, two: 0u16}`)', /home/rustbuild/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/test/run-pass/extern-pass-TwoU16s.rs:28
------------------------------------------
task <unnamed> failed at 'explicit failure', /home/rustbuild/src/rust-buildbot/slave/auto-linux-32-nopt-t/build/src/compiletest/runtest.rs:778
test [run-pass] run-pass/extern-pass-TwoU16s.rs ... FAILED
[...]
alexcrichton commented
gah sorry! I was looking at extern-return-* instead of extern-pass-*. My bad.
huonw commented
triage: still broken