Is this repo really open source ?
guimard opened this issue · 5 comments
Hi,
it impossible to reproduce lib/mappings.wasm build. The result given by https://github.com/fitzgen/source-map-mappings is different and doesn't work.
Why do you provide closed-source file ? Is there something hidden ?
There is a difference between a binary being not reproducible and a binary being proprietary.
It seems to me like lib/mappings.wasm can be reproduced only with the original versions of the toolchain on the original computer 4 years ago. That doesn't make it proprietary.
Hi, like the reporter of this issue, I tried to compile source-map-mappings to get it running along with source-map.
However some source-map-mappings methods expected by source-map have not the correct names.
If there is an incompatibility between versions, it is more likely to be between source-map-mappings and source-map,
than caused by toolchain versions.
There is a difference between a binary being not reproducible and a binary being proprietary.
It seems to me like lib/mappings.wasm can be reproduced only with the original versions of the toolchain on the original computer 4 years ago. That doesn't make it proprietary.
"Original versions of the toolchain, original computer" and original own changes !
- This doesn't make it opensource
- The current compilation result is so different that there is no suggestion that the published file has any relation to the source file allegedly used
The wasm file was built in 2018 and many things changed (rust, cargo, wasm libraries and tools).
I tried very hard to try to rebuild using version from that old year, but I never managed to get the exact same binary file.
I agree with previous comment, the binary was built from sources on the other repo and nothing is hidden.
Having said that we ought to do a refresh on the wasm binary, using latest version of everything.
I'll be doing that in #465.
#465 landed.
WASM sources are now in the repo over here.
And the WASM binary has been refreshed over there.
This binary should be easily reproducible.
I mentioned the precise versions of all the environment in the commit message.