mperdeck/jsnlog.js

Updated TypeDefinitions

jFensch opened this issue · 5 comments

jFensch commented

Its appears the definitions on DefinitelyTyped are stale.

Is there a possibility to have these just included in the NPM package using the appropriate "typings" config: link?

mperdeck commented

Thanks for your suggestion. I've included the typing config and released that (version 2.17.3). Also sent pull request to DefinitelyTyped to bring definitions up to date.

jFensch commented

After the update I get the following:

File '../node_modules/jsnlog/Definitions/jsnlog.d.ts' is not a module.

Exported external package typings file '../node_modules/jsnlog/Definitions/jsnlog.d.ts' is not a module. Please contact the package author to update the package definition.

mperdeck commented

I need more detail in order to reproduce this. Specifically which commands etc. do you use when you get this error?

jFensch commented

Smallest test to reproduce here by executing npm install and then npm run test on the following repo:

https://github.com/jFensch/jsnlog-example

mperdeck commented

Thanks for the test code. I fixed the problem and released the fix as version 2.17.4.