release latest as 0.9.8, please?

Question

release latest as 0.9.8, please?

Closed this issue 12 years ago · 10 comments

Several problems have been fixed since the last release (0.9.7). Gathering these into a release would be helpful.

The fix I need is the updated dependency on connection_pool (from 0.1.0 to 0.9.0). I've built a gem that depends on girl_friday, and having the wrong connection_pool dragged in to my users' apps is problematic.

Answer 1 · 2012-08-01T21:45:05.000Z

I'll run all the specs real quick. I don't see why we can't push. @mperham that sound ok?

Answer 2 · 2012-08-01T21:50:14.000Z

Fine by me. A release has been on my todo list for about a month now.

Answer 3 · 2012-08-01T21:50:38.000Z

Should it be 0.9.8 or 0.10.0?

Answer 4 · 2012-08-01T21:54:56.000Z

0.1.0 sounds good.

Answer 5 · 2012-08-01T21:55:33.000Z

Er, you know what I meant. 0.10.0

Answer 6 · 2012-08-01T22:03:34.000Z


15:02:13 jesse@chino:~/projects/girl_friday (git:master:9edea0f)  jruby-1.6.7.2@gf 
∴ rake
jruby 1.6.7.2 (ruby-1.9.2-p312) (2012-05-01 26e08ba) (OpenJDK 64-Bit Server VM 1.7.0_03) [linux-amd64-java]
/home/jesse/.rvm/gems/jruby-1.6.7.2@gf/gems/flexmock-minitest-1.0.1/lib/flexmock/minitest.rb:4 warning: already initialized constant VERSION
Run options: --seed 44751

# Running tests:

F.............NOTE: MiniTest::Unit::TestCase#assert_block is deprecated, use assert. It will be removed on 2013-01-01. Called from /home/jesse/.rvm/gems/jruby-1.6.7.2@gf/gems/flexmock-0.9.0/lib/flexmock/core_class_methods.rb:64:in `check'
NOTE: MiniTest::Unit::TestCase#assert_block is deprecated, use assert. It will be removed on 2013-01-01. Called from /home/jesse/.rvm/gems/jruby-1.6.7.2@gf/gems/flexmock-0.9.0/lib/flexmock/validators.rb:54:in `validate'
Unable to shutdown queue (1)
.......

Finished tests in 32.899000s, 0.6383 tests/s, 1.5198 assertions/s.

  1) Failure:
test_0001_provides a status structure for each live queue(GirlFriday::.shutdown!) [/home/jesse/projects/girl_friday/test/test_girl_friday.rb:32]:
Expected: 0
  Actual: 1

21 tests, 50 assertions, 1 failures, 0 errors, 0 skips
org.jruby.exceptions.RaiseException: (SystemExit) exit
rake aborted!
Command failed with status (-1): [/home/jesse/.rvm/rubies/jruby-1.6.7.2/bin/...]

Tasks: TOP => default => test
(See full trace by running task with --trace)

Answer 7 · 2012-08-01T23:52:22.000Z

I don't have time to look into this. Either we ship it with the race condition or we don't ship it until someone else can track it down and fix it. wdyt?

Answer 8 · 2012-08-01T23:56:37.000Z

Personally I would prefer it fixed before shipping a release. Even though I use it on 1.9.3 I'm not a fan of shipping when we have a known, failing spec. That's my $0.02

Answer 9 · 2012-08-02T03:47:20.000Z

Overrode you, dude. When in doubt,

Answer 10 · 2012-08-02T03:48:43.000Z

Heh, well it is your project 😄