mpociot/versionable

Versions table versionable_id and versionable_type

emilv opened this issue · 1 comments

emilv commented

I believe versionable_id should be unsigned. increments() creates an unsigned integer column.

I also think it would be better, at least for performance, if versionable_type was a string (varchar) instead of text. Varchars can usually be stored in the row inline so they require one less disk seek than a text or blob column. This is especially important if one wants to search based on the column.

emilv commented

versionable_id should also be indexed since it is searched on updating a model.