Shot chart detail only has made shots
shaunwhyte opened this issue · 8 comments
shaunwhyte commented
Hey is it possible to make the shot chart details also show missed shots?
Love the work so far!
shaunwhyte commented
i looked into the api request and it only returns the made shots so this may be unsolvable for now...
shaunwhyte commented
This can be altered to also show the missed shots, is that something ya'll want?
mpope9 commented
Hey, good catch I didn't notice that endpoint was only returning made shots. Fixing this would be awesome. I currently don't see how we can get missed shots through the parameters we are passing. Have you been able to trigger missed shots?
shaunwhyte commented
I can make a small pull request if you like?
mpope9 commented
Yes, that'd be very welcome.
shaunwhyte commented
Do I need permission to push a branch?
mpope9 commented
Na, you can fork the repo, create your own branch, then create a PR off of that.
…-------- Original Message --------
On Aug 5, 2021, 12:17 AM, Shaun Whyte wrote:
Do I need permission to push a branch?
—
You are receiving this because you commented.
Reply to this email directly, [view it on GitHub](#48 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACS2JGTKZKFGJY744TRZTPDT3I3IBANCNFSM5BQWHEBQ).