[auto_profiles] using `video-out-params` properties as a condition results in severe OSC lag
dyphire opened this issue · 2 comments
Important Information
Provide following Information:
- mpv version: git master
- Windows Version: Win11 22H2
- Source of the mpv binary: https://github.com/zhongfly/mpv-winbuild/releases/tag/2023-11-06
- If known which version of mpv introduced the problem
Reproduction steps
- using
video-out-paramsproperties as a profile-cond to auto-profiles in mpv.conf, for example:
[test]
profile-cond=p["video-out-params/gamma"] == "bt.1886"
profile-restore=copy
target-trc=auto
- Open video and play
- Open osc for operation
Expected behavior
The video is playing normally and the osc is also working properly
Actual behavior
The video is playing normally without any frame drops. the osc severely lags behind.
test.mp4
Log file
Sample files
Natural consequence of 84de84b.
Thinking about this again it's indeed not good. mpv-android for example also observes video-params and will now receive useless property updates every frame. (is it possible to observe sub-properties?)
We can revert this. It is not even property update, but VOCTRL that staggers the updates.
Probably need new event for image params changes, not all of them cause vo reconfigure, but having it on tick is not good if VOCTRL is involved.
EDIT:
I will think into removing this VOCTRL, because there is no good way to handle this in fact if we keep those params in video-params.
Even if we add support for subprop get it would be still a problem if anyone would like to observe one of those hdr params.