z=0 changed for yappCoordPCB?
sakana280 opened this issue · 2 comments
For cutouts on front/back/left/right sides, the p(1) coordinate (z height in model coordinate) currently aligns with the underside of the PCB, though the coordinates documentation indicates it should align with the top surface of the PCB. It looks like this was changed when introducing support for multiple PCBs - references to pcbZ were replaced with getPCB_Z which doesn't include the board thickness.
Was this a deliberate change to the z=0 reference point? If it's a bug, I think replacing all 7 usages of getPCB_Z with getPCB_Za will restore the z=0 level to the top surface of the PCB. So far I've only testing with side plane cutouts, so I'm not sure if there are wider impacts of this Z->Za change.
The example Multiple_PCB_v30.scad includes pcbThickness() offsets for the p(1) components which is why those cutouts align to the board top surface.
Update released
Thank you!