Use latest Yojson
Closed this issue · 2 comments
Lupus commented
Latest Yojson library (version 2 and higher) has dropped legacy json type, would be nice to bump the version of required yojson library along with the corresponding change in code generator. It's very cosmetic change, no other APIs are affected and everything works just fine. See corresponding PR to ocaml-protoc-yojson: mransan/ocaml-protoc-yojson#2
c-cube commented
Should we also move to Yojson.Safe.t? Seems like most projects use this variant…
Lupus commented
Probably this change also makes sense. ppx_yojson_conv is producing Yojson.Safe in generated code as well.