rewrite history

[glensc]

hi @mrclay,

i was wondering, if you be interesting doing git filter branch to trim history to include only files that are jsmin-php related.

it would be probably very good idea to do that before you merge any of the PRs here.

[mrclay]

Is this really necessary? This seems quite difficult since the files have been moved around several times. The stuff I'd want to keep:

(all current files)
min/lib/JSMin.php
lib/JSMin.php
lib/jsmin.php
lib/Minify/3rd_party/jsmin.php
lib/Minify/Javascript.php
min_unit_tests/test_JSMin.php
min_extras/unit_tests/test_JSMin.php
min_unit_tests/_test_files/js/
min_extras/unit_tests/_test_files/js/

[glensc]

yes, git ls-files from current master should be kept

i'll try to make up something in my fork and see

[glensc]

here's something i quickly throw together: https://github.com/glensc/jsmin-php/tree/rebase
and one with files on master only: https://github.com/glensc/jsmin-php/tree/rebase-only-master
and the above with empty commits removed: https://github.com/glensc/jsmin-php/tree/rebase-only-master-no-merges2

and finally as you wanted it:
https://github.com/glensc/jsmin-php/tree/rebase2
(but it seems broken, will check tomorrow this)

[glensc]

so if you still think it's good idea, you should probably fetch the wanted master branch, git reset hard and push -f to github to ovewrite your master with the new one. (can give exact commands if needed).

and after that the pull requests should work fine.

[mrclay]

Your filtering looks good. Still not convinced it's a good idea. This is being used on Packagist; how will it affect those users?

[glensc]

really up to you. but packagist problem is what? if tag by same version is recreated, it should no problem for clients to understand git forced push.

close if you reject the idea. otherwise i will have to work more on this, as somewhy last commit removed all files. huh