mrclay/minify

`intervention/httpauth` has a new version to make Laravel 7 work

edalzell opened this issue · 5 comments

edalzell commented

Any chance you can update?

I'll take a look at a PR in a bit.

edalzell commented

I can't get the tests to run because I'm on PHP 7.4, I'll roll back to 7.3 to see if we can move this forward a bit.

Stolz commented

I'm also looking forward this. I'm the maintainer of Stolz/Assets, a package somehow popular among Laravel users. The package itself does work fine with Laravel 7 but it cannot be installed because it depends on current version of mrclay/minify, which in turn depends on intervention/httpauth:2.0 which is not compatible with Laravel 7. The author of intervention/httpauth has made it compatible with Laravel 7 in recent 3.x versions

glensc commented

I'm happy to review pull request

  • 👍1
edalzell commented

@glensc see #666 . I needed to change the test files to bring PHPUnit more current then change the test classes to make the method signatures properly match. I also remove the php5.3 restriction as that's quite old.

edalzell commented

thank you!