PHP 8 support?
angrybrad opened this issue · 6 comments
angrybrad commented
PHP 8 will be officially released in 4 days.
As it currently it, this library won't be installable via Composer if you're running PHP 8 because of https://github.com/mrclay/minify/blob/master/composer.json#L32
Are there plans to add support for PHP 8?
glensc commented
This repo exists purely on contributions.
angrybrad commented
@glensc All of the tests are passing on 8.0rc2 at least:
ubuntu@nitro-dev:~/sites/minify$ /usr/bin/php8.0 /usr/local/bin/composer test
> phpunit
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.
...................S..............S..SSSS.SSSS......SIS.
Time: 3.47 seconds, Memory: 8.00MB
OK, but incomplete, skipped, or risky tests!
Tests: 56, Assertions: 85, Skipped: 12, Incomplete: 1.
I've made a PR for this #682 - didn't add it to travis.yml as it appears they don't have PHP 8 support yet.
keldrox commented
Waiting for version for php8, thanks!