mrennie/crossfire

Breakpoints are always enabled even when not

mrennie opened this issue · 1 comments

mrennie commented

FF 11 + FB 1.9.1 + CF 0.3a11

Steps:

  1. connect your favorite client
  2. create a breakpoint in FB
  3. toggle its enabled state

The trace below is the onToggleBreakpoint event sent immediately after toggling the enabled state to diabled in Firebug - notice it still reports the breakpoint is enabled:

[CROSSFIRE]READ PACKET: Content-Length:243\r\n\r\n{"seq":22,"type":"event","event":"onToggleBreakpoint","contextId":"xf0.3::4945450","body":{"breakpoint":{"handle":20,"type":"line","location":{"url":"http://www.google.ca/","line":4},"attributes":{"enabled":true,"condition":null}},"set":true}}

mrennie commented

The fix for issue #5 also contains the fix for this issue.

See commit: https://github.com/firebug-crossfire/crossfire/commit/0cec0f90da50b9a80f936df4acebc2960316b60a