Multiple scripts defining Cc, Ci, and Cu as "const"

Question

Multiple scripts defining Cc, Ci, and Cu as "const"

itewksbu opened this issue 13 years ago · 3 comments

Both the SocketTransport.js and CommandLineHandler.js define the global Cc, Ci, and Cu variables as "const". The side effect of this is that CommandLineHandler is loaded before SocketTransport. Then when SocketTrasnport is loaded it fails at trying to define Cc as "const" since it is already defined. Then when crossfire.js attempts to load it fails because SocketTransport failed to load. So then the entire extension point fails to work.

Answer 1 · 2012-03-26T15:37:18.000Z

I pushed a fix to: https://github.com/firebug-crossfire/crossfire/commit/4ec13658209df0426fb43ceec23fddb7ef1204fc

that removes all use of the aliases for those types, that way it does not matter what order they are loaded in.

Answer 2 · 2012-03-26T15:44:37.000Z

not sure what happened but that last commit did not include the changes to SocketTransport.js, which are here:

https://github.com/firebug-crossfire/crossfire/commit/4b4c34be85e80fc50c7fa32b89bd8a77c55a0f90

Answer 3 · 2012-03-26T17:45:06.000Z

HEAD works for me now.