mrgrim/MUP

MC-134989 patch conflicts with FoamFix "fasterPropertyComparisons"

Closed this issue · 3 comments

zomabies commented

When MC-134989 patch and FoamFix fasterPropertyComparisons are both enabled, the game crashes before it reaches the main menu.

Tested on:
foamfix-0.10.1-1.12.2.jar
mup-1.2.0.jar
forge 14.23.4.2759

Crash log: https://paste.dimdev.org/ujakicuruq.mccrash

Relevant FoamFix config

# Optimizes blockstate property equals and hashCode methods. [default: true]
B:fasterPropertyComparisons=true

Workaround: Setting one of the mod configuration to false prevents the crash.

mrgrim commented

Thank you for the report! I've had very little time to perform compatibility testing, so these are very helpful. For now I would recommend using FoamFix's version and unticking the "Load Patch" configuration in EUP.

I'll hold this open until I've had time to implement a general purpose conflict detection and resolution system that can auto-disable patches, disable the ability to configure them, and provide a useful notification to the user as to why.

mrgrim commented

Conflict management will be in the next release.

8adf060

Closing.

  • ❤️1
zomabies commented

Thank you for fixing this!