mrhaydendp/Fire-Tools

Auto Updater does not work with minor versions

Closed this issue · 2 comments

Describe the Bug:

A clear and concise description of what the bug is.

Steps to Reproduce:

Steps to reproduce the behavior:

  • Install 24.04 on Linux
  • Run app
  • Click the update button in the top left
    SCR-20240428-nfcx (MacOS)

Expected Behavior:

Converts "24.04.1" to a float (which is completely impossible)

Platform:

  • Linux/MacOS (reproduced on both)

Additional Context (Optional):

Floats can't store double decimal numbers like "24.04.1", those aren't "real" numbers

No idea how to solve this, since looking over your code, it should work fine

EDIT: looked over the recent additions and saw that the update issue was fixed. However, anyone using the updater will encounter issues unless they download the newest raw file from Github directly

Yeah I realized that soon after I made the fix but haven't had time to update the release with the patched version. I'll have some time tonight to update it. Thank you for looking out!

Maybe add a big banner in the README saying smth along the lines of "If you came here because of updater issues, they have been resolved; download latest version"