mrlesmithjr/ansible-rabbitmq

FYI, `debian | add Rabbitmq erlang repo key` task is unnecessary

jf opened this issue · 4 comments

jf commented

https://github.com/mrlesmithjr/ansible-rabbitmq/blob/master/tasks/debian.yml:

- name: debian | adding RabbitMQ public GPG key to the apt repo
  apt_key:
    url: "{{ rabbitmq_debian_repo_key }}"
    state: present
  become: true
  register: result
  until: result is successful

- name: debian | adding RabbitMQ repo
  ...

- name: debian | add Rabbitmq erlang repo key
  apt_key:
    url: https://bintray.com/user/downloadSubjectPublicKey?username=rabbitmq-erlang
    state: present
  become: true
  register: result
  until: result is successful
when: rabbitmq_debian_erlang_from_rabbit

rabbitmq_debian_repo_key, which is the same url as the url for the debian | add Rabbitmq erlang repo key task (see https://github.com/mrlesmithjr/ansible-rabbitmq/blob/master/defaults/main.yml#L26) is already added to apt_key in the first task above; there is no point in conditionally checking whether the same key should be added again.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jf commented

For the record, as of today, the "2" keys are still one and the same. Maybe it doesn't matter anymore (it is May 1st, or going to be May 1st, depending on bintray's definition), but:

$ curl -s https://bintray.com/user/downloadSubjectPublicKey?username=rabbitmq | md5sum
afb32f368add6c48dcccedb72189119c
$ curl -s https://bintray.com/user/downloadSubjectPublicKey?username=rabbitmq-erlang | md5sum
afb32f368add6c48dcccedb72189119c
mrlesmithjr commented

Thanks for the feedback. We should go ahead and get this resolved.