ms-studio/karmilla

Single quotes/apostrophe [‘’]

Closed this issue · 2 comments

nclm commented

Hi!
Nice adjustment of the ’ in Karmilla! Some related additional things I’m thinking about:

  • It is corrected in Regular, but not in Bold.
  • If ’ is corrected, ‘ is not. Won’t it look odd now when ‘quoting’ the British way?
  • What should be the relationship between the single quotes and the dots of the i and j, should they be at the same altitude? I’m not sure about this.

‘’

I’d love to try doing the revisions by the way (I’m waiting for your answer first) — I want to contribute to an open typeface for a while now, and I really like Karla Karmilla.

Indeed, I corrected it only in the Regular weight, and for the only apostrophe that is used in French.

You are right, it would be good to align the others as well – feel free to go ahead.

Nice to have more contributors!

nclm commented

I did the changes and sent a pull request for you to review: #12 :)
Was not sure how to do for the versioning, so there’s an edited font-log but maybe it’s not right. Also are exported two .ttf, but the files are lighter than the previous ones while I didn’t removed anything. Maybe something to do with export settings?
Anyhow, glad to contribute even at such a small level!