"Max Length" property value is no longer saved into diagram file after update to 1.3.0.6

Question

"Max Length" property value is no longer saved into diagram file after update to 1.3.0.6

mmarinchenko opened this issue 5 years ago · 11 comments

I've just updated EF Designer from version 1.3.0.4 to 1.3.0.6. After that I've opened my test diagram and re-saved it. Max Length constraint disappeared.

Then I tried to set Max Length constraint in Properties window and saved diagram one more time. No luck.

So I opened diagram file in text editor. No Max Length value inside.

I use VS 2017 (15.9.16).

Answer 1 · 2019-10-03T05:51:09.000Z

Thanks for the catch. Been working on a feature change for string length, where you can explicitly state that the string should be maximum available length, to remove the annoyances of getting a warning for 0-length string. That code got merged before it was ready.

It's yanked out now and the fix is in 1.3.0.7.

Answer 2 · 2019-10-03T06:29:35.000Z

Many thanks for quick response, Michael!

Answer 3 · 2019-10-05T01:19:38.000Z

v1.3.0.7 is now in the Releases section here on GitHub. Please let me know if you still experience any problems with this.

Answer 4 · 2019-10-05T04:48:22.000Z

Ok, thank you! I'll try new version next week.

Answer 5 · 2019-10-07T07:32:59.000Z

I've just installed v1.3.0.7 (over v1.3.0.4) and tested it with my diagram.

The only thing I found not very convenient is change in default AutoProperty value. To keep the previous behavior I had to go through all the properties and manually change the value to "True".

Everything else seems to be working fine. Thank you!

Answer 6 · 2019-10-07T08:41:33.000Z

Hmm. Thanks. You should not have had to do that - it should be the default. I'll make sure to check that out and fix if it got flipped for some reason.

I appreciate you're testing it out.

Answer 7 · 2019-10-07T10:26:07.000Z

As far as I understand the original diagram files (saved in v1.3.0.4) didn't have explicit autoProperty attributes in properties configuration.

So while reading XML (in v1.3.0.7) the absence of attributes were treated as they have "False" values. Therefore in the UI the values were set to "False" but bolded because at the UI level the default is "True".

P.S. At the entity level "AutoProperty Default" values were correctly set to "True". I didn't have to change them manually.

Answer 8 · 2019-10-07T12:42:03.000Z

Yes, but they have a default 'true' value that's being set but then stepped on by the modeling sdk framework. Most odd. I've started digging into this already.

Answer 9 · 2019-10-09T03:25:24.000Z

Thanks for the info on the AutoProperty attribute acting up. That's resolved now. Unfortunately, any model that might have been edited with 1.3.0.6 or 1.3.0.7 may have the overrides embedded in its data now. An annoyance, to be sure.

Answer 10 · 2019-10-09T06:36:01.000Z

Thank you for your prompt support, Michael.

Answer 11 · 2019-10-27T00:21:57.000Z

Fix available for review in v1.3.0.8-pre