Unidirectional Many-to-One Association missing Required (EF Core)
majoreffort opened this issue · 3 comments
An unidirectional association from Entity1 to Entity2 where End 1 is many and End 2 is one should have the required attribute set / configured for the navigation property on Entity1 to Entity2. See the following simple diagram:
With the current extension version 1.3.0.12 and EF Core this is missing, neither the Required attribute on the property nor the fluent IsRequired for the foreign key gets generated. Interestingly, "Required" is inserted into the summary comment of the navigation property.
By the way: Awesome tool! Really makes working with EF (Core in my instance) so much more pleasant.
Thanks for the nice words. Glad that this fun little project is helping!
Let me see if I understand what you're saying by rewording a bit, because I believe I do see the problem.
The context currently builds the model as
modelBuilder.Entity<global::Sandbox.Entity1>().ToTable("Entity1").HasKey(t => t.Id);
modelBuilder.Entity<global::Sandbox.Entity1>().Property(t => t.Id).IsRequired().ValueGeneratedOnAdd();
modelBuilder.Entity<global::Sandbox.Entity1>().HasOne(x => x.Entity2).WithMany().HasForeignKey("Entity2_Id");
modelBuilder.Entity<global::Sandbox.Entity2>().ToTable("Entity2").HasKey(t => t.Id);
modelBuilder.Entity<global::Sandbox.Entity2>().Property(t => t.Id).IsRequired().ValueGeneratedOnAdd();
but this isn't quite right ... that defines a 0..1-* relationship. It should rather be
modelBuilder.Entity<global::Sandbox.Entity1>().ToTable("Entity1").HasKey(t => t.Id);
modelBuilder.Entity<global::Sandbox.Entity1>().Property(t => t.Id).IsRequired().ValueGeneratedOnAdd();
modelBuilder.Entity<global::Sandbox.Entity1>().HasOne(x => x.Entity2).WithMany().HasForeignKey("Entity2_Id").IsRequired();
modelBuilder.Entity<global::Sandbox.Entity2>().ToTable("Entity2").HasKey(t => t.Id);
modelBuilder.Entity<global::Sandbox.Entity2>().Property(t => t.Id).IsRequired().ValueGeneratedOnAdd();
There really aren't any foreign keys in this mix since we're letting EF create shadow properties for those (as it should be! :-) ), but the cardinality of the navigation properties is clearly messed up. This has additional repercussions as, since the T4 doesn't see the navigation property as required, it's not creating proper constructors and we get two default constructors generated for Entity1. I can't imagine how this hasn't been caught previously, so I'm guessing this must be a recent regression. We'll need to get a patch in asap.
Thanks a million!
Exactly, that's what I meant.
Regarding the constructors, the generated code seems to be correct as far as I can tell: there is a protected default one for EF and the public one requiring an instance of Entity2, so it might not be messed up completely after all.
Fixed in 2.0RC2.