Healthcheck Widget: "Details" Button with wrong URL
Opened this issue · 4 comments
Hello
LoxBerry v3.0.0.6 running at RPi4
The "Details" button of the Healthcheck widget has a wrong URL assigned:
http://loxberry/admin/system/healthcheck.cgi
"http://loxberry/" shall be replaced by the URL of the current page or like the "Home" button.
The healthcheck notification uses the hostname you’ve configured in the “Network” widget.
The URL is set at sending the notification, not on showing it. The link is individual to the notification itself, so plugins link to their website, LoxBerrys links to Wiki,…
The link is also sent via email.
No issue from my perspective.
Sorry for the delay, have to wait for the "Details" button to be back on GUI.
Please find below the source of the page:
<div style='vertical-align: middle; width:25%; display: table-cell; align:right; text-align: right;'>
<a class="btnlink" data-role="button" href="http://erdberg:80/admin/system/healthcheck.cgi" target="_blank" data-inline="true" data-mini="true" data-icon="action">Details</a>
<a href='#' class='notifdelete' id='notifdelete2' data-notifykey='2' data-role='button' data-icon='delete' data-iconpos='notext' data-inline='true' data-mini='true'>(X)</a>
</div>
erdberg is the hostname of the LoxBerry, but the / my url is erdberg.myDomain.at
But other href values of this page are like this:
<div data-href="/admin/system/logmanager.cgi" id="update_alert" style="margin-left:15px; cursor:default; display:none; width:30px; height:30px; background-repeat: no-repeat; background-image: url('/system/images/update-running.svg');"></div>
<a id="btnnotifies" href="/admin/system/tools/showallnotifications.cgi" class="headerbutton pi pi-bell"></a>
<a id="btninfo" href="#infopanel" class="headerbutton pi pi-question-circle"></a>
<a id="btnpower" href="/admin/system/power.cgi" class="headerbutton pi pi-power-off"></a>
<!--<div data-href="/admin/system/power.cgi" id="btnpower_alert" style="position:relative; right:-25px; pointer-events: none; visibility:hidden; width:30px; height:30px; padding:0px, border:0px, z-index:10000, background-repeat: no-repeat; background-image: url('/system/images/reboot_required.svg');"></div>-->
</div>
Is it possible to have the "Details" button in the same manner as the others of this page?
Thanks!
The URL is set at sending the notification, not on showing it. The link is individual to the notification itself, so plugins link to their website, LoxBerrys links to Wiki,…
The link is also sent via email.
Whereas the other url‘s are created by the user interface, not by the notification.
Maybe we can get an additional config field named "Fully qualified domain name (FQDN)" as part of the "Network" widget?
This FQDN shall be used by the healthcheck notification and others too.
I think that would be helpful in case of using a reverse proxy too, isn't it?
What do you think?
Thanks!