Solana: port transaction submission API from web3.js
mschneider opened this issue · 7 comments
mschneider commented
aniketfuryrocks commented
Willing to work on this
Lioncat2002 commented
Willing to work on this as well
Lioncat2002 commented
@mschneider
Added the requestAirdrop
function
I have two questions before I create a new PR
- How do I write a new test
Since the hash that that gets returned by the rpc client changes everytime
There isn't really anything that can be compared to check if the test passed. - The
rpc_url_
that you seem to be using in all the post request is set to the main net which doesn't have therequestAirdrop
method
So, should I set the postrequestAirdrop
url todevnet
ortestnet
?
mschneider commented
requestAidrop should increase the sol balance of the wallet
mschneider commented
you can specify devnet url when creating the Connection object
mschneider commented
I noticed that the some of the new methods return json
as response type. Please make sure you parse the json responses and created proper types for them, similar to what web3.js does. This will help users of the API to leverage type based auto completion to use the library more efficiently.
aniketfuryrocks commented
- Added (Serialize json returns to structs) as a part of #43