what_defined, pub_moduledoc

Question

what_defined, pub_moduledoc

Closed this issue 7 years ago · 9 comments

Deleted user commented 7 years ago

Firex not function in my version of Elixir 1.4.4.

With

Answer 1 · 2017-06-20T18:43:33.000Z

@msoedov I have fork the project for try to correct the problem my-self.

Answer 2 · 2017-06-20T19:18:49.000Z

@ZackEyston Thanks for the report. I have not tested it with 14.4 yet but with 14.4 it worked fine:
https://travis-ci.org/msoedov/firex . I will take a look to this a bit latter

Answer 3 · 2017-06-20T19:21:43.000Z

@msoedov Okay, thx, I think it's cause by nil in to_op_types. I work it.

Answer 4 · 2017-06-20T19:23:10.000Z

@ZackEyston any patch will be appreciated :)

Answer 5 · 2017-06-20T19:56:32.000Z

Okay, i have correct the wraning and correct the bug :)

Answer 6 · 2017-06-20T20:02:00.000Z

I have make a pull request, you can close this if all stuff is correct.

Answer 7 · 2017-06-21T00:58:45.000Z

@ZackEyston Thanks for contribution, I have added 1.4.4 to travis build matrix

Answer 8 · 2017-06-21T06:42:57.000Z

@msoedov Thx too, Firex is useful 👍 , and correct the version of Firex in README please, haha :)

Answer 9 · 2017-06-23T02:44:33.000Z

@msoedov So, if you check my pull request, close this issue. :)