mstorsjo/msvc-wine

Installed *.exe wrappers are not symlinks

huangqinjin opened this issue · 3 comments

*.exe in wrappers are symlinks, but they are installed by plain cp command, and thoses symlinks are resolved to normal files. Is it intentional? It not, cp -a should be used.

cp $ORIG/wrappers/* bin/$arch

*.exe in wrappers are symlinks, but they are installed by plain cp command, and thoses symlinks are resolved to normal files. Is it intentional? It not, cp -a should be used.

No, I don't recall a reason for that being intentional, thanks for bringing it up.

FWIW, the cp in older versions of macOS didn't use to support the -a flag, but I believe that it might have been added quite a long time ago (probably over 10 years ago), so it's probably quite fine to rely on it at this point.

I pushed 1272d55 on a branch, I can merge it to master if the CI looks good.

I pushed 1272d55 on a branch, I can merge it to master if the CI looks good.

LGTM!

I pushed 1272d55 on a branch, I can merge it to master if the CI looks good.

LGTM!

Pushed now in 7c55b2c.