msys2/msys2-installer

[CRITICAL] Uninstall when `symlinks` are present destroys linked folders

adamleerich opened this issue · 2 comments

Hello, I created a symlink to a folder on my C drive (where I keep my github projects). I had to uninstall MSYS2 while trying to fix a bug in another project's build. When uninstalling, the folder on my C drive (not properly part of the MSYS2 folder) was completely cleared. Most of the work in there is pushed to github, so I think I am OK, but I wanted to flag this.

I'll create a script that recreates the issue, if that is helpful, but I wanted to raise this now because I think it is critically dangerous, unexpected behaviour.

Thanks

--Adam

lazka commented

hm, that's unfortunate indeed. We just use the QT installer framework which handles the uninstall process for us, so not sure if we can change anything there.

I'll do a test to see if I can recreate the issue. If I can, would you be amenable to adding an alert to the uninstaller or the website to tell people who use symlinks to be careful?