mszostok/codeowners-validator

Files checker does not support globstar patterns (**)

Closed this issue ยท 6 comments

the validator uses go's built in filepath globber, which doesn't support double-asterisk patterns (golang/go#11862):

matches, err := filepath.Glob(fullPath)

using https://github.com/bmatcuk/doublestar or golang/go#11862 (comment) seems like good fixes for now.

Hi @wilrnh

Thanks for reporting that issue, this is also a part of this problem #22 and sometime ago I was doing an investigation about it and as a result I had fix on my local branch but forget to finish that. Your issue energized me to finish that, thanks! ๐Ÿ˜ƒ

glad to hear! any plans for a release soon?

glad to hear! any plans for a release soon?

ignore me, i just rtfm and saw the milestone. ill go ahead with an internal build for now. thanks for such a great project!

Thanks!

Actually, I will try to do my best to close the v0.5.0 milestone this week. I will update you when the new release will be cut off ๐Ÿ‘

Hi @wilrnh ICYMI: Yesterday I released a new v0.5.0 version of Codeowners Validator, check more here.

Sorry for the little delay:)

If you encounter any issues or bugs, please let me know:)

very nice! thank you