mszostok/version

Failing Builds

Opened this issue · 1 comments

Kamsiy commented

Description

Right now, the tests for the project are currently failing due to a mismatch in dates.

For example:
Build: https://github.com/mszostok/version/actions/runs/4269505384/jobs/7432733388?pr=87
Screen Shot 2023-04-28 at 1 24 39 AM

Steps to reproduce

  • Create a pull request

Troubleshooting

  • I looked into updating the date and time for the github actions OS but this is not allowed Screen Shot 2023-04-28 at 1 33 49 AM

  • We could add some code to normalize the dates but this might hide issues in future Pull requests

  • Regenerating fixtures fixes this as well

mszostok commented

I'm aware of that issue. Thanks for the PR with updated assets. I will leave this issue open to figure out a proper solution. Maybe a CI that will do the update and will create a PR, sth similar to what dependabot is doing. Mocking is also an option but not sure if it will be a better one, as the final code path won't ever be tested.

  • 👍1