mt-caret/polars-ocaml

Compilation fails on Ubuntu 23.04

edwintorok opened this issue · 3 comments

Works fine on Fedora37, but on Ubuntu 23.04 I get:

#=== ERROR while compiling polars.0.0.1 =======================================#
# context     2.1.2 | linux/x86_64 | ocaml.4.13.1 | https://opam.ocaml.org#bd109444
# path        /local/home/edvint/.opamubuntu23/default/.opam-switch/build/polars.0.0.1
# command     /local/home/edvint/.opamubuntu23/default/bin/dune build -p polars -j 8 @install
# exit-code   1
# env-file    /local/home/edvint/.opamubuntu23/log/polars-7004-f87155.env
# output-file /local/home/edvint/.opamubuntu23/log/polars-7004-f87155.out
### output ###
# [...]
# 171 |                 if entering.is_some_and(|em| $new_is_m(&self.m, em.1) || empty_overlap) {
#     |                             ^^^^^^^^^^^
# ...
# 204 | minmax_window!(MaxWindow, get_max_and_idx, new_is_max, n_sorted_past_max);
#     | ------------------------------------------------------------------------- in this macro invocation
#     |
#     = note: see issue #93050 <https://github.com/rust-lang/rust/issues/93050> for more information
#     = note: this error originates in the macro `minmax_window` (in Nightly builds, run with -Z macro-backtrace for more info)
#
# For more information about this error, try `rustc --explain E0658`.
# error: could not compile `polars-arrow` due to 2 previous errors
# warning: build failed, waiting for other jobs to finish...

I think this is because Ubuntu 23.04's Rust version is too old, but I'm not 100% sure.

Ubuntu23.04:

rustc --version
rustc 1.67.1 (d5a82bbd2 2023-02-07) (built from a source tarball)

Fedora37:

rustc 1.73.0 (cc66ad468 2023-10-03) (Fedora 1.73.0-1.fc37)

What is the minimum required version?

It seems like the minimum required version is 1.70.0. I've added some info into the cargo metadata that should make this explicit.