mudgen/diamond-2

Possible integer overflow

dxhash opened this issue · 0 comments

In the functions diamondCut (library/LibDiamond.sol and contracts/facets/DiamondCutFacet.sol), selectorCount is updated by conversion from uint256 to uint16, which may cause overflow. This could lead to wrong behavior of DiamondLoupeFacet: facets, facetFunctionSelectors, facetAddresses functions may return corrupted values.