mufeedvh/binserve

Emojis are not getting Rendered Properly

Tibinsunny opened this issue ยท 4 comments

Hey,
Unicoded Emojies like ๐Ÿ˜‹ ๐Ÿ“™ are not Getting Rendered Properly.

Eg:
If I edit my "template_variables" in binserve.json to

"template_variables": {
"load_static": "/static/",
"name": "This is test ๐Ÿ˜‹"
}

The Index page get rendered as ๐Ÿ‘‡

SS

And I believe this is something that should be fixed! Right?

OS:Windows 10 64Bit
Binserve used : binserve-v0.1.0-x86_64-pc-windows-gnu.exe

Hey @Tibinsunny,

Nice Catch! โค๏ธ This is indeed something to be fixed. I think this issue is caused by Handlebars because that's the package doing all the template rendering work so it seems like this should be fixed on their side although there might some hacky way I can sanitize the template_variables to support Unicode emojis. I will look into it!

Thanks for the detailed issue, I will resolve this ASAP! ๐Ÿ‘

Probably related to the UTF-8 flag I mentioned before.

Hello @robjtede,

It was indeed related to the UTF-8 flag .prefer_utf8(true).

Screenshot from 2020-10-14 23-09-45

Thank You @robjtede! โค๏ธ๐Ÿ™Œ
I will push the fix right away! ๐ŸŽ‰

This issue has been fixed! ๐Ÿ‘

Thank You @Tibinsunny @robjtede! โค๏ธ๐Ÿ™Œ