Move the ASCII art to a separate file

Question

Move the ASCII art to a separate file

AMythicDev opened this issue 4 years ago · 5 comments

I was inspecting your sources, The ASCII art didn't looked good in the middle of the source code. It would be better if you move it to a separate file or maybe make it a const. Also the line that tells about the host and port could be put along with the ASCII art. You should use the include_str! macro to include it into the source code during compilation and use it in the println! also specifying the host and port

Answer 1 · 2020-10-03T18:03:16.000Z

Hey @arijit79, thanks for raising this issue! This is indeed a good way to do, I will make a banner file that gets printed out with include_str! during execution. It does seem messy inside the code, I will definitely push this change soon! ❤️🙌

Answer 2 · 2020-10-03T18:03:50.000Z

Also, unrelated to this issue, but something related to formatting is that your files in the static folder are all in one line, you should probably format them according HTML writing styles. If you use an IDE like VSCode or Atom, they have plugins to improve the formatting of HTML

Answer 3 · 2020-10-03T18:12:45.000Z

I just made it one-liners because it's default generated templates and short in LOC. But yes it would improve readability in format, thank you for the request, I will definitely look into this as well. 😃👍

Answer 4 · 2020-10-03T18:14:22.000Z

I will filing a PR to fix the HTML issue

Answer 5 · 2020-10-03T18:17:33.000Z

Awesome @arijit79, thank you! ❤️🙌