muhlba91/pulumi-proxmoxve

How to disable replacing CTs on `pulumi up`?

Closed this issue · 4 comments

pcuci commented

Can't figure out the pulumi, or tf-provider, option to not replace the CTs on every pulumi up

Is this allowed, possible?

Not sure I understand the rationale to always recreate the containers on pulumi up, the behaviour for VMs is exactly the opposite, IMO the expected behaviour (ie: update/patch, not replace).

can you please provide an example, and the outcome of a pulumi preview?
i suppose something changed that forces replacement; for this it's necessary to have as many details as possible.

pcuci commented

Sure thing (it's very possible I'm doing something wrong?):

image

Screenshot for the omega stack at this commit: https://gitlab.com/home.cloud/infra/cloud/-/blob/cff349851787bf400cf281f688142c6330ca34aa/src/ct/index.ts#L73-104

To not confuse my OpenWRT router, I generally stick to deleteBeforeReplace: true; however, disabling this (I commented it out to reproduce the "bug"), should result in the default behaviour which recreates the CT before the proxmoxve provider deletes it.

Thanks for any hints, @muhlba91 ! 😄

your code doesn‘t set the disk property. hence, the default one applies and i guess then a diff is detected. when previewing, can you select details to see what exactly changed in the disk property?
that should give you a hint on what you need to set in your code to propose the same configuration than the container has after creation.

if you really don‘t want/need to set the disk property a simple way to ignore that property is the pulumi resource option ignoreChanges to be set to ['disk'].

pcuci commented

Fantastic, with ignoreChanges I get the "desired" behaviour:

image

I'll probably just daisy chain the disk property from the template to the containers, to avoid the default reset, and stay explicit about what's happening.

Thank you very much!