multiformats/cs-multibase

Nonstandard encoding

eth-r opened this issue · 4 comments

eth-r commented

The encoding used by this library in bases 2, 8 and 10 is non-standard and incompatible with other implementations, conflicting with the intent of the multibase project

Ok, I will look into this. When this was implemented there was no specification or other implementations for reference, so I hope there will be some test vectors all implementation can test against soon.

eth-r commented

I proposed a set of test vectors in multiformats/multibase#24 to help standardize the libraries

Nice, that's just what I need. I'll start working on this asap. Thank you.

@eth-r Released a new version of the library, it's completely rewritten and passes all your test vectors now and fixes multiformats/multibase#34.