multiformats/js-multihash

Add keccak256 support

kumavis opened this issue · 7 comments

kumavis commented

pending acceptance to standard and assignment of a code: multiformats/multihash#54

daviddias commented

code assignment done, wanna add this feature to js-multihash, js-multihashing and js-multihashing-async?

kumavis commented

yep. tracking here:

  • js-multihash #21
  • js-multihashing
  • js-multihashing-async
  • 👍1
kumavis commented

@diasdavid @dignifiedquire can you verify we need both js-multihashing and js-multihashing-async ?

dignifiedquire commented

@diasdavid @dignifiedquire can you verify we need both js-multihashing and js-multihashing-async ?

We only use js-multihashing-async at this point, so imho there is no need to add it to js-multihashing.

daviddias commented

I would rather keep both modules consistent with the same features. There are way more users of multihashes than just IPFS users

dignifiedquire commented

Implemented it in multihashing-async: multiformats/js-multihashing-async#4

  • 😄1
  • 🎉1
kumavis commented

Closing in favor of tracking here multiformats/js-multihashing#14