Code table mismatch
theobat opened this issue · 7 comments
cc @kevina any idea ? (this is for my currently opened PR in js-multibase which -depending on this- is ready to be merged or not
the csv, the README need to be fixed.
@kevina, thanks for the answer, there's a PR live for the fix.
There's one thing I do not understand though and I think we should include an explanation for it in the readme (and/or update the input/output examples). What does it mean when you have several letters ? (such as 'Ff' for base 16 or 'Cc')
Is it meant to use both in the encoded output ?
@theobat if there is an upper and lower case level are case letter all it means is the encoding is is case insensitive for example F2X67 or f2x67 is okay for a hex encoding of a hash.
Thanks @kevina, then I'm wondering which one of these approach is the best :
- case insensitive comparisons on the specific cases
- a list of acceptable code(s) for each encoding
Any of these still require a default code value for the concat' operation.
The first one would require less complexity but in case we want to add distinct char as acceptable codes in the future (which seems higly unlikely though) the second one is better.
Any preference is welcome. Without answer I'll go for the first choice.