Editing option panel for MEM

[Edouard2laire]

Hello

Describe the bug
When using the process, Sources > Compute sources: BEst, we can open the panel to enter the MEM option using the Edit button. After entering all the parameters, and closing it by clicking "ok". If we try to reopen the panel using again the Edit button, an error appears.

To Reproduce
Steps to reproduce the behavior:

1. Go to Sources > Compute sources: BEst
2. Click on Edit and enter some parameters
3. Click on Ok.
4. Click again on Edit and see the error

Screenshot

(1)

(2)

(4)

Expected behavior
When clicking again on Edit, the previously entered parameter should appear in the edit panel.

Additional context
The error also appears for NIRS

@ftadel, I am tagging you in case you have any idea on how to solve this bug :)

[Edouard2laire]

hi @rcassani

I started to work again on that issue and reorganized the panel so its easier to debug and it is almost fully functional:
https://github.com/Edouard2laire/best-brainstorm/blob/new_panel/gui/panel_brainentropy.m#L124-L159

However, I have some issues with the display and how vfill / hfill works

First, the reference panel gets all squished although I specified a minimum size then when I hide some components, the other components don't move to fill the blank but leave a gap in the window which looks quite weird:

Do you think you could have time to help me on that?

Thanks a lot,
Edouard

[rcassani]

Hi @Edouard2laire, a panel that behaves more or less as you wish is panel_inverse_2018

Do you think you could have time to help me on that?

Could you generate mock-ups for the three options?
Also, which branch is the one to test those changes?

[Edouard2laire]

Hi.

The branch is new_panel from my fork: https://github.com/Edouard2laire/best-brainstorm/tree/new_panel

here is an illustration showing left what the code is producing vs what I am trying to achieve:

Basically on the left, all the blank spaces correspond to options that are only shown during wMEM or rMEM.

I looked at the example and at the panel we did for nirstorm; but I am still not sure about why the hidden panel still take room in the main panel, creating those blank spaces.

[Edouard2laire]

hi @rcassani ,

I know you are very busy, but I was wondering if you had a bit of time to look into that issue? We will soon be able to merge #13 in Best, so I would like to fix those panel issue at the same time so we can announce the new panel at the same time of the release :)

Let me know if you would like us to meet to check that together.
Edouard

[Edouard2laire]

Closing as it is solved in #13