multinet-app/multinet-client

Disable create and delete table buttons for insufficient workspace permissions

Closed this issue · 4 comments

As of now, you can still click the buttons and fully access the menus of actions which may be unavailable to you, namely table/graph creation/upload/deletion. Since these actions will fail in the end, we should simply disable these buttons if the user does not have the appropriate permissions, perhaps also showing a tool-tip on hover that conveys that it's disabled due to their permission level.

This would also apply to workspaces. As of now, you can select any number of workspaces for deletion, whether or not you have the permissions to actually delete them. These should be similarly disabled unless you have this access (in this case only the owner).

Below are some screenshots illustrating these buttons/menus.

Screenshot from 2020-11-19 15-57-17

Screenshot from 2020-11-19 15-57-49

Marking this as good first issue, since it's non-urgent in the short term, but important to fix, and something a newcomer could cut their teeth on.

@waxlamp
Am I eligible to take on this issue? Is it worth it to fix in the deployed version of the client or is it something to get into the girder4 branch, now that permissions functionality is about to be incorporated there?

@waxlamp
Am I eligible to take on this issue?

Yes.

Is it worth it to fix in the deployed version of the client or is it something to get into the girder4 branch, now that permissions functionality is about to be incorporated there?

Just target the girder4 branch.

Thanks Mike!

Closed via #202