Contribute: Mention ready-to-test Pull requests

Question

Contribute: Mention ready-to-test Pull requests

Closed this issue 3 years ago · 6 comments

toby63 commented 4 years ago

For example @TerryGeng is searching for testers for this PR (mumble-voip/mumble#4694), so it might be useful to:

add a special label (in main repo), like "test-requested" or similar
mention this label in the contribute guide

What do you think?

Answer 1 · 2021-02-03T06:28:19.000Z

There already is such a label: needs-testing

Answer 2 · 2021-02-03T13:43:50.000Z

Thanks for the follow-up.

The PR you have mentioned is still considered to be unmatured and more work has to be done in order to get it merged. I will change it into WIP.

Answer 3 · 2021-02-03T20:21:59.000Z

@TerryGeng

The PR you have mentioned is still considered to be unmatured and more work has to be done in order to get it merged. I will change it into WIP.

Ok, so you don't want testers for now.

@Krzmbrzl While that is good, it doesn't really answer the question, should I add a mention of that or not?
There are multiple PRs we had, that would fit, mostly audio, but also grpc etc.
Even though right now, not so much is going on.

Answer 4 · 2021-02-03T23:48:39.000Z

Ok, so you don't want testers for now.

I do want someone to tell me if it works and in what situation it works or doesn't work.

Can you help me test it?

Answer 5 · 2021-02-04T08:09:21.000Z

should I add a mention of that or not?

I don't think that it would change that much since we can't label a PR and then leave it there until someone external finally comes around testing it. Thus I expect PRs having these labels only for a rather short period of time.
I think people should rather focus on testing development snapshots and/or build from current master and test that. That would probably fit our development process better 🤔

Answer 6 · 2021-02-04T16:40:33.000Z

@TerryGeng

I do want someone to tell me if it works and in what situation it works or doesn't work.

That's the definition of Testing.
But maybe I missunderstood your first comment, so I guess you would like a note on the website for PRs that should be tested?

Can you help me test it?

No, I don't have a Mac.

@Krzmbrzl

I think people should rather focus on testing development snapshots and/or build from current master and test that. That would probably fit our development process better 🤔

Well it's all your decision.
One argument for the mention is that testing was requested multiple times before the PRs are merged.
If we mention it, more people could be aware of that.