facts that trace cause munki-facts to trace

Question

facts that trace cause munki-facts to trace

Closed this issue 7 years ago · 4 comments

if munki-facts has a script that has a python trace error, it will cause munki-facts to also fail.

Munki-facts should handle this and move on to the next fact, without losing the other conditions.

Answer 1 · 2017-08-22T21:08:54.000Z

I would accept a PR that addresses this. Or if you aren't likely to provide one, could you at least provide a fact that fails?

Answer 2 · 2017-08-22T21:15:17.000Z

I can provide one later today. I was issuing an issue just so I wouldn't forget.

Answer 3 · 2017-08-22T21:20:51.000Z

https://gist.github.com/erikng/3246bed1ad1d87345ec38dddd2254fb8

This should trace at the loginwindow, due to a TypeError (ultimately caused by user being None). if you name it something like a_fact.py it will be one of the first facts ran.

Answer 4 · 2017-08-22T21:38:09.000Z

365c45b should address this.