Add more indents

Question

Add more indents

3timeslazy opened this issue 5 years ago · 10 comments

I think it would be useful to allow users to select indents in the generated scheme, so as not to violate the company's rules.

It can be like this:

# t for tab
# {n}s - amount of spaces
gqlmerge --ident=t (or 2s, 4s) PATH OUTPUT

Answer 1 · 2019-05-22T15:42:42.000Z

Ready to make PR, if needed

Answer 2 · 2019-05-22T16:11:08.000Z

Good idea, why not?

Answer 3 · 2019-05-22T16:12:59.000Z

Let's list possible options for this.

t (tab)
2
4

or just --indent={any integer}

In case of 2, 4, I don't think it is needed s after number of space. What do you think?

Answer 4 · 2019-05-22T16:35:04.000Z

@mattdamon108 I think the follow pattern will be good:

# n - amount of idents
# i - ident (`t` for tabs and `s` for spaces)
--ident={n}{i}

if n is not stated 1 will be used

--ident=t is equal to --ident=1t

Answer 5 · 2019-05-22T22:47:13.000Z

I agree on your idea. If you're willing to make a PR, let me know or I'll work on it.

Answer 6 · 2019-05-23T08:21:57.000Z

@mattdamon108 i will

Answer 7 · 2019-05-23T08:47:48.000Z

@3timeslazy on 🔥 👍

Answer 8 · 2019-05-26T18:02:48.000Z

@mattdamon108 Hey! Review PR pls #19

Answer 9 · 2019-05-27T00:07:57.000Z

@3timeslazy Thank your for your work! Sure thing, I'll review it.

Answer 10 · 2019-05-27T05:54:32.000Z

@3timeslazy there is some bug when it runs with options e.g. gqlmerge -v. It is caused by -v or -h is not parsed by flag. So I PR after fixed. And I kept Merge(indent, paths) in /lib to use it inside other prjects as a library. Please check it out in lastest version.