Add Docker build check to Travis
Closed this issue · 8 comments
Currently the Travis tests do not check if the docker image builds successfully. There are two ways that I can see this going. The first is to build the docker image and then run the unit test on it too and the other is to just build the docker image.
So looking at how the unit test works we will not be able to run it in the docker container. The unit test has a number of dependencies on packages that are removed during the docker build process. I can make the needed changes to .travis.yml to make sure the docker image builds and that it runs.
I have this working on my fork. Would you like me to make a PR? As a note go test does not work on my fork.
glutton.go:11:2: cannot find package "github.com/mushorg/glutton/producer" in any of:
/home/travis/gopath/src/github.com/dpisano/glutton/vendor/github.com/mushorg/glutton/producer (vendor tree)
/home/travis/.gimme/versions/go1.7.5.linux.amd64/src/github.com/mushorg/glutton/producer (from $GOROOT)
/home/travis/gopath/src/github.com/mushorg/glutton/producer (from $GOPATH)
rdp.go:7:2: cannot find package "github.com/mushorg/glutton/protocols/rdp" in any of:
/home/travis/gopath/src/github.com/dpisano/glutton/vendor/github.com/mushorg/glutton/protocols/rdp (vendor tree)
/home/travis/.gimme/versions/go1.7.5.linux.amd64/src/github.com/mushorg/glutton/protocols/rdp (from $GOROOT)
/home/travis/gopath/src/github.com/mushorg/glutton/protocols/rdp (from $GOPATH)
smb.go:7:2: cannot find package "github.com/mushorg/glutton/protocols/smb" in any of:
/home/travis/gopath/src/github.com/dpisano/glutton/vendor/github.com/mushorg/glutton/protocols/smb (vendor tree)
/home/travis/.gimme/versions/go1.7.5.linux.amd64/src/github.com/mushorg/glutton/protocols/smb (from $GOROOT)
/home/travis/gopath/src/github.com/mushorg/glutton/protocols/smb (from $GOPATH)
Seems like the sub packages are not installed or your Gopath is not set correctly.
As per a previous discussion the errors from go test are from travis.
Do you want to to just submit a PR for for what I have for this?
Absolutely!