Add flag to enforce ${var}

Question

Add flag to enforce ${var}

AlexSkrypnyk opened this issue a year ago · 3 comments

Can we please have an option to force ${var} everywhere. This would be very useful for those of us who wants their scripts to be consistent.

p.s. Let's not turn this issue into a holy war about whether it is a right choice to have every variable to be wrapped in ${} - let people decide this.

thank you

Answer 1 · 2023-09-07T04:41:57.000Z

I ended up coming up with this https://github.com/AlexSkrypnyk/shell-var-lint until this issue is resolved

Answer 2 · 2023-09-07T11:02:50.000Z

Enforcing it for everyone would be far too aggressive; there's nothing wrong with $var. Remember that shfmt is a formatter, so it needs to lean towards being conservative.

It's perfectly fine for others to build a linter or more aggressive "consistency enforcer" tool on top of the same Go packages in this Go module. I personally don't have the time and resources for that.

Answer 3 · 2023-09-07T12:59:10.000Z

I slipped up on the reply - you asked for an option. We want to keep the number of formatting options to a minimum, to avoid something like man indent with its dozens of knobs. So the bar for them is pretty high - we only add an option when a large number of users would benefit, or when it helps satisfy a well known style guide like Google's.