mvdnes/spin-rs

Remove `panicked` field from Once's Finish guard

zesterer opened this issue · 2 comments

The question is (albeit probably very unlikely to make a difference), do we even need to perform that store? Because if panic = 'unwind' then IIRC panics will only execute destructors and not code, so shouldn't we be able to simply do core::mem::forget(finish)?

Originally posted by @4lDO2 in #109 (comment)

4lDO2 commented

I think this can be closed now, as this has been implemented by the recently merged PR above.

Closed by #112