minSDK to 26 (android 8.0)
532910 opened this issue · 7 comments
Really this is not an issue.
Could you explain what is the reason for minSDK restriction to 26?
Are you sure it's a must?
If you could make a build of the latest version but without restriction I could test it on android 7.1.
There was a strong need to move to java 8 classes in the java.time.* package and stop using Calendar for various calculations in the widget, that's why we upgraded the minSDK (issue #28).
About releasing a version with a lower minSDK, it would require a considerable amount of changes and java.util.Calendar is not the way to go (looking forward) since it's a little bit buggy compared to using instants (if you check closed issues, you'll see that few of them were because of this very same reason like #23 or #24), that's why so many projects were/are using joda time.
@mvmike perhaps add a short note about this in the README, since a considerable amount of people are on older versions of Android. Like:
minSDK: 26 (android 8.0), to use the better
java.timeJava calendar API
One alternative could be https://github.com/JakeWharton/ThreeTenABP, lowering minSdk, but making the APKs quite a bit bigger for the sake of compatibility.
Not sure what to do since it will make builds heavier and less efficient for all android versions if we want to avoid the hassle of maintaining two parallel codebases for the app... even the author states that it's extremely inefficient
True, but note that ThreeTenABP is a fork of ThreeTenBP :)
This library places the timezone information as a standard Android asset and provides a custom loader for parsing it efficiently.